fix(etag): change where to check for crypto
#3916
Conversation
EdamAme-x
changed the title
crypto
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3916 +/- ##
==========================================
+ Coverage 91.28% 91.31% +0.03%
==========================================
Files 168 168
Lines 10757 10673 -84
Branches 3166 3053 -113
==========================================
- Hits 9819 9746 -73
+ Misses 937 926 -11
Partials 1 1 ☔ View full report in Codecov by Sentry. |
|
Hi @EdamAme-x Do you mean this PR will resolve #3914? If so, I think this approach is good. |
|
The context is slightly different. The main direction of this PR is to solve the problem of checking for the presence of a crypto api, even though it uses a hash generation method that does not use a crypto api. Of course, as you may be thinking, this PR may improve compatibility as a side effect. |
|
Okay. |
There was a problem hiding this comment.
Hi, @EdamAme-x. Thank you for creating a pull request.
There is no need to adopt my branch as they are, but I would like to convey the following in my comments.
EdamAme-x/hono@fix/etag-if-bug...usualoma:hono:fix/etag-if-bug-2
|
ready |
|
@EdamAme-x Thank you! |
This PR allows users to specify a hash generation function even in environments where there is no crypto, so the place to check for
cryptochanges.#3832
The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the code